Fix use-after-free bug in nmslib engine query path #1305
Merged
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
jmazanec15
added
Bug Fixes
Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
force-pushed
the
issue-1304
branch
from
dfe764e
to
20b13fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1305 +/- ##
=========================================
Coverage 85.13% 85.13%
Complexity 1210 1210
=========================================
Files 160 160
Lines 4931 4931
Branches 449 449
=========================================
Hits 4198 4198
Misses 537 537
Partials 196 196 ☔ View full report in Codecov by Sentry. |
heemin32
approved these changes
Nov 13, 2023
ryanbogan
approved these changes
Nov 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 7c4d4e4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ties
datavariable to lifetime ofIndexWrapperby making it struct member as opposed to local constructor variable. This change reflects the structure ofIndexWrapperbefore opendistro-for-elasticsearch/k-NN@7640186.Add unit test. The unit test sometimes reproduces the issue. However, it is difficult to reproduce deterministically. I was able to reproduce on my mac fairly consistently, but not able to reproduce on linux.
Issues Resolved
#1304
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.